Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull arch-specific docker-compose in Ubuntu Dockerfiles #282

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Pull arch-specific docker-compose in Ubuntu Dockerfiles #282

merged 2 commits into from
Dec 3, 2024

Conversation

dszeto2
Copy link
Contributor

@dszeto2 dszeto2 commented Nov 27, 2024

Pull request

Describe your changes

Building my own multi-arch images using docker buildx, I noticed that the docker-compose is always pulling the x86_64 flavor. Changing to pull the specific TARGETARCH architecture.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests and documentation

@some-natalie
Copy link
Owner

  1. THANK YOU! ✨ ✨ ✨
  2. Not sure if it changes anything, but that GHES / Octodemo runner isn't really built or tested anymore. There's an internal-to-GitHub instance of GHES for field folks to demo, which I used to run the runners for some of those demos. Not sure who owns it now.
  3. I tested it locally because I messed up some actions permissions somewhere and won't bother debugging it. It works :)

@some-natalie some-natalie merged commit 6e79660 into some-natalie:main Dec 3, 2024
7 of 11 checks passed
@some-natalie
Copy link
Owner

And thank you! ❤️

@dszeto2
Copy link
Contributor Author

dszeto2 commented Dec 3, 2024

Ah, I wasn't looking to use the ghes-demo Dockerfile specifically, but I figure this change I wanted in rootless-ubuntu-numbat.Dockerfile was relevant elsewhere that my commit was for completeness. 🙂

Kudos to your repo and blog to be a guiding GitHub CI resource! ❤️

@dszeto2 dszeto2 deleted the use-arch-for-docker-compose branch December 3, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuCaSiNo40 LuCaSiNo40 LuCaSiNo40 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dszeto2 @some-natalie @LuCaSiNo40